Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: Move default toleration to values.yaml so it can be overriden #1400

Merged
merged 1 commit into from
Sep 28, 2022
Merged

helm: Move default toleration to values.yaml so it can be overriden #1400

merged 1 commit into from
Sep 28, 2022

Conversation

cnmcavoy
Copy link
Contributor

Is this a bug fix or adding new feature?
Bug fix. Users can not override or remove the default toleration for taints in the current helm chart.

What is this PR about? / Why do we need it?
Moves the default toleration for NoExecute for 300s to the values.yaml, which is where default values should be defined. This allows users to provide their own complete set of tolerations which can override the default toleration.

What testing is done?
Helm template verification.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 27, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @cnmcavoy!

It looks like this is your first PR to kubernetes-sigs/aws-ebs-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-ebs-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @cnmcavoy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 27, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 27, 2022
@cnmcavoy cnmcavoy changed the title Move default toleration to values.yaml so it can be overriden helm: Move default toleration to values.yaml so it can be overriden Sep 27, 2022
@torredil
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2022
@ConnorJC3
Copy link
Contributor

Can you also make the same fix in the windows daemonset? (otherwise this will break windows users):

aws-ebs-csi-driver/charts/aws-ebs-csi-driver/templates/node-windows.yaml

Lines 40 to 47 in fcf2fa7

{{- if .Values.node.tolerateAllTaints }}
- operator: Exists
{{- else }}
- operator: Exists
effect: NoExecute
tolerationSeconds: 300
{{- end }}
{{- with .Values.node.tolerations }}

Otherwise lgtm

@cnmcavoy cnmcavoy force-pushed the cnmcavoy/override-taints branch from f4bc2be to ad80aef Compare September 27, 2022 20:04
@ConnorJC3
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 27, 2022
@torredil
Copy link
Member

/lgtm

@gtxu
Copy link
Contributor

gtxu commented Sep 28, 2022

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cnmcavoy, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit a8adf9c into kubernetes-sigs:master Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torredil torredil torredil approved these changes

@bertinatto bertinatto Awaiting requested review from bertinatto

Assignees

@ConnorJC3 ConnorJC3

@gtxu gtxu

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cnmcavoy @k8s-ci-robot @torredil @ConnorJC3 @gtxu